Passing extra parameters in ActiveStorage::Blob#url to S3 Client
#42504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one, thanks for the PR. Can you please add a changelog entry? |
josegomezr
force-pushed
the
activestorage_s3_pass_client_opts
branch
from
713da93
to
f847558
Compare
|
My pleasure, entry added & resolved conflicts with main. |
josegomezr
force-pushed
the
activestorage_s3_pass_client_opts
branch
from
f847558
to
cc3f2c5
Compare
|
@josegomezr Could you squash your commits too please? 🙇 |
This allows calls of `ActiveStorage::Blob#url` to have more interaction with the S3 Presigner, enabling, amongst other options, custom S3 domain URL Generation. Closes rails#42488
josegomezr
force-pushed
the
activestorage_s3_pass_client_opts
branch
from
cc3f2c5
to
302f708
Compare
|
@zzak Squashed 🦾 ! |
|
If I understood correctly the contribution guide: after the contribution is merged to main, in order to make it into the next release cycle I'll need to patch the |
|
No new features are added to stable branches. Those changes will only be released in Rails 7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows calls of
ActiveStorage::Blob#urlto have more interaction with the S3 Presigner, enabling, amongst other options,custom S3 domain URL Generation.
Closes #42488