Output UJs test failures in CI #42513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghiculescu
commented
Jun 16, 2021
ghiculescu
added a commit
to ghiculescu/qunit-selenium
that referenced
this pull request
Jun 16, 2021
This allows you to print out all the qunit output, not just the summary. See rails/rails#42513 for an example of why.
ghiculescu
force-pushed
the
ci-ujs-tests
branch
3 times, most recently
from
1488d18
to
94404f6
Compare
lfalcao
approved these changes
Jun 17, 2021
rafaelfranca
requested changes
Jun 17, 2021
ghiculescu
commented
Jun 17, 2021
ci/qunit-selenium-runner.rb
Outdated
| require "webdrivers" | ||
| # This class based on https://github.com/smontanari/qunit-selenium, with a few tweaks to make it easier to read output. | ||
| # Copyright (c) 2014 Silvio Montanari | ||
| # License: MIT |
There was a problem hiding this comment.
@rafaelfranca is this okay, or do we need the full text?
There was a problem hiding this comment.
This is the most similar scenario to this that I could find: https://github.com/rails/rails/blob/main/guides/rails_guides/levenshtein.rb#L6
There was a problem hiding this comment.
reading the license I believe it needs to be the full text.
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
zzak
reviewed
Jun 18, 2021
zzak
approved these changes
Jun 23, 2021
rafaelfranca
added a commit
that referenced
this pull request
Jun 23, 2021
Output UJs test failures in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found out in #42512 that the test failures from UJs tests don't print out in CI, or when you run the tests locally. The number of assertions shows, but not which individual ones broke.
Currently we use https://github.com/smontanari/qunit-selenium which is a thin wrapper over
::Selenium::WebDriverthat parses the results. I have taken the relevant code from that gem and brought it in house, then added some extra methods to read the raw output from the test results, and print it out when tests fail. I've also offered the changes upstream (smontanari/qunit-selenium#3), but as the gem hasn't been updated in 7 years I thought it would be better to include them directly in here.Here's an example of the output you'll now get when tests fail: https://gist.github.com/ghiculescu/3cdaf74b051b8ce022f79f39285ac4f8
Here's an example in CI: https://buildkite.com/rails/rails/builds/78360#87935aa0-3d6c-44cb-b7f4-384bc59117db
It's not pretty, but it's a big improvement over not seeing the results at all.