Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failing in Active Storage's GCS service #42536

Merged
merged 2 commits into from
Jun 19, 2021

Conversation

maleblond
Copy link
Contributor

@maleblond maleblond commented Jun 18, 2021

Summary

Ref. #42509 (comment)

This PR should fix two tests in main that are failing since #42509: https://buildkite.com/rails/rails/builds/78375#6fb6fd5c-1d74-4491-b9c8-97ee7ad52c67

Error:
--
ActiveStorage::Service::GCSServiceTest#test_upload_with_cache_control:
NoMethodError: undefined method `delete' for nil:NilClass
/rails/activestorage/test/service/gcs_service_test.rb:132:in `ensure in block in <class:GCSServiceTest>'
/rails/activestorage/test/service/gcs_service_test.rb:132:in `block in <class:GCSServiceTest>'

We were trying to use a variable that doesn't exist (service_config instead of SERVICE_CONFIGURATIONS). Those tests only run in the main branch, which is why this failure wasn't caught before the PR was merged

@maleblond maleblond changed the title Fix test failing in GCS service Fix test failing in Active Storage's GCS service Jun 18, 2021
@pixeltrix pixeltrix merged commit cde84b8 into rails:main Jun 19, 2021
@pixeltrix
Copy link
Contributor

@maleblond thanks for following this up 👍🏻

@pixeltrix
Copy link
Contributor

Ugh, I missed the second commit - for future reference, please squash those out, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants