-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci skip] Add link with full list of options for S3-compatible services #42548
[ci skip] Add link with full list of options for S3-compatible services #42548
Conversation
Does this work with Active Storage out of the box? I don't see edit: oh wait, |
I think we should not add documentation for services that are not officially supported 🤔 but I could be missing some context here as I also have no idea what minio is.. |
minio is a storage service compatible with S3 with a community edition. I thought that it was more popular. Some teams use it on production, of course, but also for development. Maybe the problem is on the AWS documentation (linked in the guides), for me was not clear what options can I use until I found this yard documentation. Since "minio" is just another s3 compatible service and the API can change, maybe it would make sense to point to the yard documentation and remove the "minio" example. I will push a more generic proposal later. |
@ceritium I think it would be better if this was updated in the AWS documentation directly. Do they accept PRs? |
ace6d7e
to
559b110
Compare
@ghiculescu they accept PRs. I can try to improve their docs too. But in any case, I think that this PR can help to rails devs experience. I just pushed a new approach. Let me know what do you think. |
Yep, I like that much better 👍 |
@ceritium Could you squash your commits please? 🙇 |
Add a link to AWS S3 yard documentation on the ActiveStorage guide under section "S3-compatible storage services".
559b110
to
05e0125
Compare
@zzak, I kept both commits to allow review of the PR with all the context. I already squashed them and rephrased the commit. Thanks! |
Summary
Add a link with a full list of options for S3-compatible services.
It was a bit hard for me to find the proper configuration for "minio" (S3-compatible), so I guess it would help others.