Documentation for ActionController::API use neutral language [ci skip] #42562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HParker
reviewed
Jun 22, 2021
| @@ -37,7 +37,7 @@ module ActionController | |||
| # == Renders | |||
| # | |||
| # The default API Controller stack includes all renderers, which means you | |||
| # can use <tt>render :json</tt> and brothers freely in your controllers. Keep | |||
| # can use <tt>render :json</tt> and siblings freely in your controllers. Keep | |||
There was a problem hiding this comment.
using family related names at all seems weird to me already. What do you think about using something like,
Suggested change
| # can use <tt>render :json</tt> and siblings freely in your controllers. Keep | |
| # can use <tt>render :json</tt> and related methods freely in your controllers. Keep |
I think siblings is also better, so this change is a 👍 from me either way.
There was a problem hiding this comment.
siblings is more correct here because it is talking about render text: which is not a new method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tiny copy-edit to use gender-neutral language:
brothers->siblings. Completes the work of #31231.