Time#change should pass the zone property through if it's set
#42583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghiculescu
force-pushed
the
time-change-with-zone
branch
from
82e9f43
to
27b7c82
Compare
ghiculescu
commented
Jun 23, 2021
| @@ -159,6 +159,8 @@ def change(options) | |||
| ::Time.new(new_year, new_month, new_day, new_hour, new_min, new_sec, new_offset) | |||
| elsif utc? | |||
| ::Time.utc(new_year, new_month, new_day, new_hour, new_min, new_sec) | |||
| elsif zone && zone.is_a?(ActiveSupport::TimeZone) | |||
| ::Time.new(new_year, new_month, new_day, new_hour, new_min, new_sec, zone) | |||
There was a problem hiding this comment.
my first attempt at a fix merged this branch and the next one, but Time.new doesn't like zones formatted as some kinds of strings, eg. it was crashing on ::Time.new(new_year, new_month, new_day, new_hour, new_min, new_sec, "CST")
There was a problem hiding this comment.
time.zone isn't necessarily an instance of ActiveSupport::TimeWithZone - Ruby allows any object there as long as it quacks in the correct manner. Perhaps a zone.respond_to?(:utc_to_local) would be better?
There was a problem hiding this comment.
That's the docs I was trying to find! I'll tidy it up, thanks.
ghiculescu
force-pushed
the
time-change-with-zone
branch
from
27b7c82
to
49a81b1
Compare
DNNX
reviewed
Jun 24, 2021
|
@ghiculescu Can you add a changelog too plz? 🙇 |
ghiculescu
force-pushed
the
time-change-with-zone
branch
from
49a81b1
to
4cc47ca
Compare
ghiculescu
force-pushed
the
time-change-with-zone
branch
from
4cc47ca
to
d132095
Compare
|
👍 changelog added |
zzak
approved these changes
Jun 25, 2021
pixeltrix
approved these changes
Jun 26, 2021
pixeltrix
added a commit
that referenced
this pull request
Jun 26, 2021
Backport #42583: `Time#change` should pass the `zone` property through if it's set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42467