Backport #42583: Time#change should pass the zone property through if it's set
#42612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzak
reviewed
Jun 26, 2021
|
|
||
| *Alex Ghiculescu* | ||
|
|
||
|
|
There was a problem hiding this comment.
We normally leave two line spaces between versions
There was a problem hiding this comment.
@pixeltrix Ahh, good to know! I didn't realize the difference between stable branch changelogs, thank you for sharing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to pass a zone object was only introduced in 2.6 but the
respond_to?check for theutc_to_localmethod should ensure that branch doesn't get called so there's no need to conditionally define the method. However we do need to skip the additional tests on Ruby 2.5.