Reset @association_scope when resetting an association
#42643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollieh-m
force-pushed
the
reset-scope
branch
3 times, most recently
from
6a45e54
to
85f9469
Compare
ollieh-m
changed the title
@association_scope when resetting an association
ghiculescu
reviewed
Jun 29, 2021
intrip
reviewed
Jun 30, 2021
intrip
reviewed
Jun 30, 2021
|
@ollieh-m Honestly I don't know enough to say if calling |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
I think we still want this, could you rebase? |
ollieh-m
force-pushed
the
reset-scope
branch
from
f2df9ad
to
845270e
Compare
Done 👍 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #42637
When we load an association (
active_service_contract) on an object (car), then reset that association (car.association(:active_service_contract).reset), the next time the association is loaded should trigger a fresh query to find any associated record.This PR aims to ensure that's the case.
After loading an association on an object then resetting the association, calling
saveon the object has the effect of loading the association again (as part ofAutosaveAssocation#save_has_one_association). Currently, when the association is loaded in this way, the query to find the associated record is based on theassociation_scopeas it was evaluated originally. The conditions are not re-evaluated, meaning they can be stale. (In the test case in this PR, an expiredservice_contractis returned as if its expiry is still in the future, because the timestamp in the scope has become out-of-date.)With this PR, the stale
association_scopeisresetwhen we callAssociation#reset, so when the association is next loaded (including as part ofAutosaveAssocation#save_has_one_association), theassociation_scopegets re-evaluated and the values included in it are current.