Use optimistic Rails version constraint in plugins #42685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanhefner
commented
Jul 2, 2021
Comment on lines
+409
to
+403
| def rails_version_specifier(gem_version = Rails.gem_version) | ||
| [">= #{gem_version}"] | ||
| end |
There was a problem hiding this comment.
This overrides Rails::Generators::AppBase#rails_version_specifier.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
jonathanhefner
force-pushed
the
plugin-optimistic-rails-version
branch
from
e33ef2c
to
a8978ec
Compare
A pessimistic Rails version constraint makes sense for an app, but plugins often must be compatible with multiple minor and major versions of Rails. Therefore, default to an optimistic constraint for plugins.
jonathanhefner
force-pushed
the
plugin-optimistic-rails-version
branch
from
a8978ec
to
feb9f64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pessimistic Rails version constraint makes sense for an app, but plugins often must be compatible with multiple minor and major versions of Rails. Therefore, default to an optimistic constraint for plugins.