assert_changes works on including ActiveSupport::Assertions class

[pedrosnk]

Summary

Hi beloved rails team. This is my attempt to fix #42869.

On the two possible approaches that I proposed on the issue, moving the alias to the Assertions module doesn't work because the alias assignment happens on loading the class, which fails because the method that the alias will redirect to doesn't exist yet. So I just renamed the method to use the original one from rails that

assert_not_equal is an alias for refute_equal that is defined only on the class ActiveSupport::TestCase. This commit ensures ActiveSupport::Testing::Assertions#assert_changes doesn't depends on ActiveSupport::TestCase to work.

Other Information

As I said on the issue I created, this used to work on 6.0.4 and on previously rails versions, stopped worked after we upgraded to rails 6.1

The code that I'm running started to fail on rails 6.1 is something like

require "minitest/autorun"
require "active_support/testing/assertions"

describe :assert_changes do
  include ActiveSupport::Testing::Assertions

  it "counts" do
    counter = 1
    assert_changes( -> { counter } ) do
      counter = 2
    end
  end
end

[ghiculescu]

This looks good, it looks like 074265a is the culprit. Are there any other methods that need fixing or just assert_changes?

[pedrosnk]

This looks good, it looks like 074265a is the culprit. Are there any other methods that need fixing or just assert_changes?

The only place that uses an assert_* that is not aliased is this one as I could see.