Make preload_link_tag work with images #43088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateberkopec
force-pushed
the
preload-images
branch
from
ae256be
to
2ceb21f
Compare
|
This PR is an abstraction/general case of #42892. |
nateberkopec
force-pushed
the
preload-images
branch
from
2ceb21f
to
3f1766e
Compare
|
Could you add a changelog entry for this? Other than that LGTM, I'd be happy to merge. |
nateberkopec
force-pushed
the
preload-images
branch
from
3f1766e
to
46bfd08
Compare
|
@byroot Donezo. EDIT: accidental close/reopen lol |
|
Hum, lot's of failures on CI, but you just got unlucky. Thanks! |
kaspth
pushed a commit
that referenced
this pull request
Aug 24, 2021
Make preload_link_tag work with images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change,
preload_link_tagwith an image would generate a tag without anasattribute. If theasattribute doesn't get set, browsers tend to ignore thelinktag (confirmed in Chrome), making the tag useless.This change fixes the issue.
After a quick look at the valid values for as in a preload tag, I don't think there are any other ones missing that could be detected from the file's mime type or extension.