Temporarily disable Azure service tests #43091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p8
force-pushed
the
activestorage/disable-azure-tests-for-now
branch
2 times, most recently
from
a8b5d39
to
f52efcf
Compare
byroot
reviewed
Aug 25, 2021
| @@ -68,7 +68,7 @@ class ActiveStorage::Blobs::RedirectControllerWithOpenRedirectTest < ActionDispa | |||
| end | |||
| end | |||
|
|
|||
| if SERVICE_CONFIGURATIONS[:azure] | |||
| if false # SERVICE_CONFIGURATIONS[:azure] | |||
There was a problem hiding this comment.
Also rather than false, something like !ENV['CI'], so that if someone get their hands on the credentials they can run the suite locally.
There was a problem hiding this comment.
I've added a comment and moved the disabling to the intialization of the SERVICE_CONFIGURATIONS as suggested by @dhh.
p8
force-pushed
the
activestorage/disable-azure-tests-for-now
branch
2 times, most recently
from
e2f3b87
to
6a5d66f
Compare
The Azure service tests are currently failing on the main branch, probably because of configuration. We can temporarily disable them while we get things working again.
p8
force-pushed
the
activestorage/disable-azure-tests-for-now
branch
from
6a5d66f
to
82f25aa
Compare
eugeneius
pushed a commit
that referenced
this pull request
Sep 23, 2021
The Azure service tests are currently failing on the main branch, probably because of configuration. We can temporarily disable them while we get things working again.
eugeneius
pushed a commit
that referenced
this pull request
Sep 23, 2021
The Azure service tests are currently failing on the main branch, probably because of configuration. We can temporarily disable them while we get things working again.
eugeneius
pushed a commit
that referenced
this pull request
Sep 23, 2021
The Azure service tests are currently failing on the main branch, probably because of configuration. We can temporarily disable them while we get things working again.
alxekb
pushed a commit
to alxekb/rails
that referenced
this pull request
Nov 18, 2021
The Azure service tests are currently failing on the main branch, probably because of configuration. We can temporarily disable them while we get things working again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Azure service tests are currently failing on the main branch, probably because of
configuration. We can temporarily disable them while we get them working again.