Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GUIDES] Fix ActiveJob custom serializer typo [ci-skip] #43095

Merged
merged 1 commit into from Aug 25, 2021
Merged

[GUIDES] Fix ActiveJob custom serializer typo [ci-skip] #43095

merged 1 commit into from Aug 25, 2021

Conversation

cpjmcquillan
Copy link
Contributor

@cpjmcquillan cpjmcquillan commented Aug 25, 2021 •
edited

Summary

Correct config/initializer/custom_serializers.rb to
config/initializers/custom_serializers.rb.

Other information

  • Fix typo in guides/source/active_job_basics.md
  • Fix 2 typos in guides/source/autoloading_and_reloading_constants.md

@rails-bot rails-bot bot added the docs label Aug 25, 2021
@p8
Copy link
Member

p8 commented Aug 25, 2021 •
edited

Thanks for the PR @cpjmcquillan !
There are two more in guides/source/autoloading_and_reloading_constants.md
Could you fix those as well?

guides/source/autoloading_and_reloading_constants.md
131:# config/initializer/custom_serializers.rb
154:# config/initializer/custom_serializers.rb

@p8 p8 added the ready PRs ready to merge label Aug 25, 2021
@cpjmcquillan cpjmcquillan changed the title Fix typo in Serializers section [GUIDES] Fix ActiveJob custom serializer typo Aug 25, 2021
@cpjmcquillan
[GUIDES] Fix ActiveJob custom serializer typo
f2fa3ec 
Correct `config/initializer/custom_serializers.rb` to
`config/initializers/custom_serializers.rb`.

- Fix typo in guides/source/active_job_basics.md
- Fix 2 typos in guides/source/autoloading_and_reloading_constants.md
@cpjmcquillan
Copy link
Contributor Author

Thanks for the PR @cpjmcquillan !
There are two more in guides/source/autoloading_and_reloading_constants.md
Could you fix those as well?

guides/source/autoloading_and_reloading_constants.md
131:# config/initializer/custom_serializers.rb
154:# config/initializer/custom_serializers.rb

No problem.

Done and I have tidied up the commits 👍.

@p8
Copy link
Member

p8 commented Aug 25, 2021

Thanks @cpjmcquillan ! 🙌

@jonathanhefner jonathanhefner changed the title [GUIDES] Fix ActiveJob custom serializer typo [GUIDES] Fix ActiveJob custom serializer typo [ci-skip] Aug 25, 2021
@jonathanhefner jonathanhefner merged commit c70e264 into rails:main Aug 25, 2021
@cpjmcquillan cpjmcquillan deleted the patch-1 branch August 25, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs ready PRs ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cpjmcquillan @p8 @jonathanhefner