Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify STI acronym [ci-skip] #43109

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Clarify STI acronym [ci-skip] #43109

merged 1 commit into from
Aug 31, 2021

Conversation

cbliard
Copy link
Contributor

@cbliard cbliard commented Aug 26, 2021

I'm not familiar with this acronym and I had to look up it. It does not mean Sexually Transmitted Infection as google suggests.

@rails-bot rails-bot bot added the docs label Aug 26, 2021
@p8 p8 added the ready PRs ready to merge label Aug 26, 2021
Copy link
Member

@p8 p8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@jonathanhefner jonathanhefner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! 😆

guides/source/upgrading_ruby_on_rails.md Outdated Show resolved Hide resolved
guides/source/upgrading_ruby_on_rails.md Outdated Show resolved Hide resolved
@jonathanhefner jonathanhefner removed the ready PRs ready to merge label Aug 26, 2021
@jonathanhefner jonathanhefner changed the title Clarify STI acronym Clarify STI acronym [ci-skip] Aug 26, 2021
@jonathanhefner
Copy link
Member

@cbliard That looks good! Would you mind squashing the commits? Then I'll give this a merge!

Co-authored-by: Jonathan Hefner <jonathan@hefner.pro>
@cbliard
Copy link
Contributor Author

cbliard commented Aug 31, 2021

@jonathanhefner sure, I just did it. Thank you for linking to the documentation about squashing. That was helpful.

@jonathanhefner jonathanhefner merged commit 8d8e5a5 into rails:main Aug 31, 2021
@jonathanhefner
Copy link
Member

Thank you, @cbliard! 😃

@cbliard cbliard deleted the patch-1 branch August 31, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants