Add HEIF image types to variable content types #43119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AVIF images are more efficient than WebP and are supported in most browsers.
HEIC is the default image format on Apple devices.
Recent versions of Imagemagick handle these image types via the HEIF module, so it seems appropriate to add them as variable content types by default.
Of these formats, only AVIF is supported by browsers, and support is not universal yet, so I did not change the default for
ActiveStorage.web_image_content_types. Even WebP is not included in this array by default, so I interpreted this default as "image types supported by all browsers."