Fix action text extra trix content wrapper #43133
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42315
Summary
When copying an
ActionText::RichText
between two models, an extra<div class="trix-content">...</div>
was added as described in the issue. This comes from the fact that anActionText::RichText
is serialized in aActionText::Content
.When the serialization happens in the
ActionText::Content.dump
method, we didn't have a case to handle serialization ofActionText::RichText
, but there is no need to serialize again. We can simply retrieve the HTML body of theActionText::Content
associatied with theActionText::RichText
.