Update webpacker guides after version upgrade [ci-skip] #43152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Good catch! 👍 When you're happy with the changes, would you mind squashing the commits?
guides/source/webpacker.md
Outdated
| @@ -51,7 +51,7 @@ To use Webpacker, you must install the Yarn package manager, version 1.x or up, | |||
|
|
|||
| NOTE: Webpacker depends on NPM and Yarn. NPM, the Node package manager registry, is the primary repository for publishing and downloading open-source JavaScript projects, both for Node.js and browser runtimes. It is analogous to rubygems.org for Ruby gems. Yarn is a command-line utility that enables the installation and management of JavaScript dependencies, much like Bundler does for Ruby. | |||
|
|
|||
| Webpacker is installed by default in Rails 6.0 and up. You can install it with a new project in some older versions by adding `--webpack` to the `rails new` command. Webpacker can be added in an existing project by running `bin/rails webpacker:install`. This installation command creates the following local files: | |||
| Webpacker is installed with a new project by adding `--webpack` to the `rails new` command. Webpacker can be added in an existing project by running `bin/rails webpacker:install`. This installation command creates the following local files: | |||
There was a problem hiding this comment.
Since the webpacker:install task is not part of Rails by default, I wanted to clarify these instructions. What do you think about the following rewording?
Suggested change
| Webpacker is installed with a new project by adding `--webpack` to the `rails new` command. Webpacker can be added in an existing project by running `bin/rails webpacker:install`. This installation command creates the following local files: | |
| To include Webpacker in a new project, add `--webpack` to the `rails new` command. To add Webpacker to an existing project, add the `webpacker` gem to the project's `Gemfile`, run `bundle install`, and then run `bin/rails webpacker:install`. | |
| Installing Webpacker creates the following local files: |
jonathanhefner
changed the title
…ult install webpacker Webpacker gem has removed the framework installer and Rails app installer has removed the support to pass the framework names to webpack option Webpacker engine guides are removed
abhaynikam
force-pushed
the
update-webpacker-guides
branch
from
04ea548
to
b7f67b4
Compare
|
@jonathanhefner Addressed the comment and squashed commits in one. Thanks 👍🏼 😊 |
|
Thank you, @abhaynikam! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple things in the webpacker guide weren't correct. Since guides point to the Rails Edge version I thought we should rectify the guides.
PR fixes following things: