-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clearer default gemfile #43212
Clearer default gemfile #43212
Conversation
@dhh, I think that it's worth defining the "minimal" version of "rack-mini-profiler" on I would appreciate some feedback on #43134 since you removed some comments here. |
The issue is not Turbo compatibility but etag compatibility, which to me seems like a fundamental and unavoidable issue. If you want 302 to mean the page didn't change, then obviously that means the speed badge also can't change, which means it'll be stale. |
Ah, I see what you mean. Sorry, I thought you were arguing whether it should be uncommented by default. I'll change the minimum version requirement. Although of course on a new app it'd still resolve to the latest. |
Added that in fdf5e00 |
I will close my PR then; I guess that if someone is interested in rack-mini-profile will read the readme and find the Turbo configuration. |
Cleanup spacing, comments, and order in the default Gemfile. Properly separating different gems. A default generation now looks like this: