Add fallback host for SystemTestCase driven by RackTest #43273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p8
force-pushed
the
actionpack/add-fallback-host-for-rack-system-tests
branch
from
ddc26bd
to
bf03089
Compare
For links to work in SystemTestCases, it requires the `host` to be added to the `default_url_options`. Since 78c7343 this is done by looking at `Capybara.app_host` or `Capybara.current_session.server_url`. This works correctly when using the Selenium webdriver, as Capybara sets either the `Capybara.app_host` or the `Capybara.current_session.server_url`. However the Capybara RackTest driver uses paths instead of URL's, so it doesn't set Capybara.app_host or Capybara.current_session.server_url. For SystemTestCase to work for the RackTest driver a host has to be available for url options. We can fallback to "http://127.0.0.1" which was the default before 78c7343.
p8
force-pushed
the
actionpack/add-fallback-host-for-rack-system-tests
branch
from
bf03089
to
4b78325
Compare
rafaelfranca
added a commit
that referenced
this pull request
Sep 21, 2021
…ck-system-tests Add fallback host for SystemTestCase driven by RackTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For links to work in SystemTestCases, it requires the
hostto be addedto the
default_url_options. Since 78c7343 this is done by looking atCapybara.app_hostorCapybara.current_session.server_url.This works correctly when using the Selenium webdriver, as Capybara sets
either the
Capybara.app_hostor theCapybara.current_session.server_url.However the Capybara RackTest driver uses paths instead of URL's, so it doesn't
set Capybara.app_host or Capybara.current_session.server_url.
For SystemTestCase to work for the RackTest driver a host has to be
available for url options. We can fallback to "http://127.0.0.1" which
was the default before 78c7343.
Fixes: #42780