clear secure password cache if password is set to nil
#43378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
doits
commented
Oct 5, 2021
doits
commented
p8
reviewed
Oct 8, 2021
```rb # before: user.password = 'something' user.password = nil user.password # => 'something' # now: user.password = 'something' user.password = nil user.password # => nil ```
doits
force-pushed
the
set_empty_secure_password
branch
from
6b9c210
to
9bd186a
Compare
rafaelfranca
added a commit
that referenced
this pull request
Oct 14, 2021
clear secure password cache if password is set to `nil`
vsppedro
added a commit
to thoughtbot/shoulda-matchers
that referenced
this pull request
Sep 28, 2022
…ails greater than 6.0 See: rails/rails#43378
vsppedro
added a commit
to thoughtbot/shoulda-matchers
that referenced
this pull request
Sep 30, 2022
* Bump Rails from 5.2.6 to 5.2.8.1 * Bump Rails from 6.0.4.4 to 6.0.6 * Bump Rails from 6.1.4.4 to 6.1.7 * test: skip validates_presence_of test with has_secure_password when rails greater than 6.0 See: rails/rails#43378 * Bump Rails from 7.0.1 to 7.0.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.