Generate [id] for FormBuilder#button called with method name
#43886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to [rails#43411][] (merged in [15f6113][]) By default, when generating a `<button>` element through a Form Builder instance, the element's `[name]` attribute is populated by calling the `FormBuilder#field_name` method. This commit assigns a matching default `[id]` attribute generated by `FormBuilder#field_id`. Additionally, it adds test coverage to ensure that calls that provide their own `name:` and `id:` options are not overridden by the default values. [rails#43411]: rails#43411 [15f6113]: rails@15f6113
|
@rafaelfranca this might be a good follow-up to (for #43411) consider for an RC. I'm sorry to have missed this the first time around. |
rafaelfranca
added a commit
that referenced
this pull request
Dec 15, 2021
…name-id Generate `[id]` for `FormBuilder#button` called with method name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to rails/rails#43411 (merged in 15f6113)
Summary
By default, when generating a
<button>element through a Form Builderinstance, the element's
[name]attribute is populated by calling theFormBuilder#field_namemethod. This commit assigns a matching default[id]attribute generated byFormBuilder#field_id.Additionally, it adds test coverage to ensure that calls that provide
their own
name:andid:options are not overridden by the defaultvalues.