Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to Unobtrusive Javascript in Rails 7.x getting started guide #44036

Closed
sockbot opened this issue Dec 31, 2021 · 1 comment
Closed

Comments

@sockbot
Copy link

sockbot commented Dec 31, 2021

Steps to reproduce

In the getting started guide for Rails 7.0.0, there are references to Unobtrusive Javascript that are deprecated now that UJS has been replaced by Hotwire Turbo in Rails 7. These references include sample code that does not work with Rails 7 because UJS is not installed.

Screen Shot 2021-12-30 at 10 18 07 PM

Expected behavior

The getting started guide should only have code samples and references that are relevant and functional in a new Rails 7 installation. All code samples and references that refer to UJS should be replaced with their Hotwire Turbo equivalents.

Actual behavior

The getting started guide should not have references or code samples that depend on UJS. Specifically, s.7.5. Deleting an Article sample code does not make a DELETE request, nor does the UJS confirmation dialog appear.

System configuration

Rails version:
7.0.0

Ruby version:
3.0.3

@sockbot
Copy link
Author

sockbot commented Dec 31, 2021

Fixed in #43941

@sockbot sockbot closed this as completed Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant