HasOneThroughDisableJoinsAssociationsTest: Use to support matching SQL of any adapter #44051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`HasOneThroughDisableJoinsAssociationsTest` assert SQL generated but doesn't handle SQL Server (quotes with `[]`). SQL Server adapter (https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/) need to coerced and re-implemented that test (rails-sqlserver/activerecord-sqlserver-adapter#975) This PR changes the test to handle all adapters.
|
This test has been failing with all bundled adapters. Here is the link to mysql2 one. https://buildkite.com/rails/rails/builds/83731#724040f0-8208-40b8-bd25-593dd022b79e/1079-1092 |
|
Thanks for the notification and sorry for the mistake. #44058 should fix the problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
HasOneThroughDisableJoinsAssociationsTestassert SQL generated butdoesn't handle SQL Server (quotes with
[]).SQL Server adapter
(https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/) need to be coerced and re-implemented that test
(rails-sqlserver/activerecord-sqlserver-adapter#975)
This PR changes the test to handle all adapters.