Document usage of enable_starttls for SMTP #44096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
added a commit
that referenced
this pull request
Jan 6, 2022
Document usage of enable_starttls for SMTP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ActionMailer smtp options are passed down to
Mail::SMTPwhich supportsenable_starttls. This option is important becauseenable_starttls_autocannot protect from a man-in-the-middle attack of the SMTP communication.
enable_starttlson the other hand refuses to communicate with SMTP serverswithout that capability, bringing
STARTTLSon par with using a dedicatedssl/tls port on server.
This change only affects documention because no code updates are needed.