Assert sql_type disregarding case sensitiveness for sqlite3 tests #44135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixeltrix
reviewed
Jan 11, 2022
As mentioned here rails#43295 since sqlite3 3.37 sqlite3 returns the type of the columns in capital letters while in versions before it did return in lowercase, matching disregarging case sensitiveness will avoid the tests fail in more recent versions of sqlite3 since what matters is the name of the type and not if it is uppercase or lowercase. Co-Authored-By: Name <pixeltrix@users.noreply.github.com>
marcelolx
force-pushed
the
fix-changes-pr-43295
branch
from
8d06393
to
1d769a1
Compare
pixeltrix
approved these changes
Jan 11, 2022
|
@marcelolx thanks for the rapid response 👍🏻 |
pixeltrix
added a commit
that referenced
this pull request
Jan 11, 2022
Assert sql_type disregarding case sensitiveness for sqlite3 tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned here #43295 since sqlite3 3.37 sqlite3 returns the type of the columns in capital letters while in versions before it did return in lowercase, matching disregarging case sensitiveness will avoid the tests fail in more recent versions of sqlite3 since what matters is the name of the type and not if it is uppercase or lowercase.
Co-Authored-By: Name pixeltrix@users.noreply.github.com