Fix flaky test case in CacheStoreBehavior #44386
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In a PR I had raised earlier, one of the test cases in ActiveSupport was failing, even though the PR did not touch any piece of code related to ActiveSupport. Upon closer inspection, I found that this is the test case that was failing:
PR: #44385
Ref: https://buildkite.com/rails/rails/builds/84552#2c168cf4-a799-4b58-a1ec-cc3032854894/1183-1205
rails/activesupport/test/cache/behaviors/cache_store_behavior.rb
Lines 408 to 412 in b961af3
Since
SecureRandom.alphanumeric
returns a string in which the alphabets are not guaranteed to be all be lowercase, it can possibly return a string with only uppercase letters and numbers present in it. And since in this test case we are testing for case sensitivity, in the rare occasion a string is returned with only uppercase letters, this test case will fail.This PR intends to account for this edge case.
Thanks!
Other Information