New test: setting response_body to a Proc should be supported. #446
Conversation
|
Cool, thanks! There were no tests for it before, so I will bring the feature back as others seem to use it. However, I plan to deprecate it, can you please tell me what is your use case? |
|
I don't use this feature and don't mind if it's deprecated. Eoin and I were at a bugmash trying to fix https://rails.lighthouseapp.com/projects/8994/tickets/6026-patch-response_body-proc-is-called-twice . |
|
Our theory was that it was broken in favor of the new HTTP streaming features. Is that why it is also going to be deprecated? |
|
@ecoffey it was removed because setting a proc to response_body never really worked. It stopped streaming since Rails 2.2 or 2.3 because of the Rack middleware stack. |
ghost
assigned
|
@josevalim gotcha. Well at least Daniel and I got a nice tour of the inner workings of actionpack dispatch :-) |
New test: setting response_body to a Proc should be supported.
use #data_source_exists? if possible instead of deprecated #table_exi…
It looks like commit a66c917 "Do not inherit from Rack::Response, remove a shit-ton of unused code." removed the possibility for the user to set response_body to a Proc. Here is a test that demonstrates this behavior working in 3.0.7 and breaking in edge.
@ecoffey