Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle net-smtp mail dependency error for Ruby 3.1 #44600

Merged
merged 1 commit into from Mar 2, 2022

Conversation

rafaelfranca
Copy link
Member

In Ruby 3.1, net-stmp is not a default gem anymore. Mail uses it as
dependency and try to loads without declaring the dependency, which
will fail unless the application have net-stmp in the gemfile.

For Rails 7 we could just make those gems dependencies of the framework.
But in Rails 6.1, which we need to support old rubies, installing those
gems can cause trouble. So instead we are intercepting the error and
telling people to add the gem to the Gemfile.

In Ruby 3.1, net-stmp is not a default gem anymore. Mail uses it as
dependency and try to loads without declaring the dependency, which
will fail unless the application have net-stmp in the gemfile.

For Rails 7 we could just make those gems dependencies of the framework.
But in Rails 6.1, which we need to support old rubies, installing those
gems can cause trouble. So instead we are intercepting the error and
telling people to add the gem to the Gemfile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants