New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rotate Default Logs on Each 100MB #44888
Conversation
Hey @berniechiu, thanks for the contribution! I agree this would be a good thing to do as I also just found some |
76cae3a
to
a85d562
Compare
Sure, no prob |
98d4f99
to
25c76f0
Compare
d44b84e
to
4d2be01
Compare
0e89bf4
to
5c63b9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good now.
I however forgot to mention that any new config
needs an entry in https://github.com/rails/rails/blob/main/guides/source/configuring.md
5c63b9c
to
b3f2bbc
Compare
b3f2bbc
to
4d6a013
Compare
Added, thanks for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor things, after that I'm good.
4d6a013
to
4cb2a44
Compare
|
All good for me, unfortunately there is a conflict in the changelog. Ping me once you rebased, and I’ll merge |
4cb2a44
to
3b4a2f6
Compare
3b4a2f6
to
2c5cff7
Compare
2c5cff7
to
cdce275
Compare
@eugeneius @byroot should be good by now, but looks like some flaky test failed in the spec? Since there's only text change in the markdown |
Summary
Also found that the default logs could grow quite big and left unnoticed, maybe we could set a default to 100MB which might already be enough for general usage and local development
Other Information
REF: #44887