Add schema awareness to Postgres create_enum
#44896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philip-maina
changed the title
create_enum
philip-maina
changed the title
create_enum
philip-maina
changed the title
create_enum
philip-maina
force-pushed
the
add-schema-awareness-to-postgres-enum-creation
branch
from
1b9dabb
to
70ff7b3
Compare
ghiculescu
reviewed
Apr 17, 2022
| end | ||
| ensure | ||
| @connection.drop_schema "test_schema" | ||
| @connection.schema_search_path = "'$user', public" |
There was a problem hiding this comment.
Rather than hard coding the value here I think you should store the current value at the start of the test and reset it here.
|
Thanks for the fix here! It’ll just need review from the core / committer team. |
philip-maina
force-pushed
the
add-schema-awareness-to-postgres-enum-creation
branch
from
70ff7b3
to
4d1b276
Compare
ghiculescu
added a commit
to ghiculescu/rails
that referenced
this pull request
Aug 6, 2022
Follow up to rails#44896 and rails#45707
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #44895 .