Bubble assertion failures back to the main thread #45061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without some help, failures in a forked process make for some noise in the output, but won't fail the build. Instead of trying to transfer the whole exception back, I've gone for a simpler solution of just sending _something_ (the exception class name) back so we'll fail; the full failure will be visible in the child process's stderr output.
zzak
pushed a commit
to zzak/rails
that referenced
this pull request
Jun 9, 2023
Bubble assertion failures back to the main thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without some help, failures in a forked process make for some noise in the output, but won't fail the build.
Instead of trying to transfer the whole exception back, I've gone for a simpler solution of just sending something (the exception class name) back so we'll fail; the full failure will be visible in the child process's stderr output.
This test is currently failing for me locally on macOS, but the more immediate concern is that it's not actually being counted as a failure. At least after this it'll be properly failing, which is.. better?