Fix: PG.connect keyword arguments deprecation warning on ruby 2.7 #45090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport rails#44346 to Rails 6.1
|
All Ruby versions failed on the same test, which suggest it is a legit error with this PR. Can you have a look at it please? |
|
Sure, I’ll take a look when I’m back on my laptop. The linked PR mentioned a failure, so I may need to backport the fix #44347 |
|
I've cherry-picked 82e90d0 onto this PR. I'll keep an eye on the outcome of: https://buildkite.com/rails/rails/builds/86496 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backport the Rails 7.0 fix #44346 to Rails 6.1.
Resolves outstanding comments on #44307