ActionView content_tag_for refactoring and improvements #4510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only check for options and prefix arguments order once when running content_tag_for with a collection.
The Post class is created everywhere in the test suite, and due to that when applying the Array() logic to refactor content_tag_for, some other change to the Post class was breaking record tag tests. The solution is to rename the class to not collide with others already defined in the test suite.
josevalim
added a commit
that referenced
this pull request
Jan 18, 2012
ActionView content_tag_for refactoring and improvements
|
Merged but please try to squash the commits in next pulls into bigger chunks. |
|
Ok, thanks :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
content_tag_fordoes not mutate the options hash.content_tag_forhelper by removing call to capture and usingArray()instead of checking forto_ary.This pull is partially related to #4341, which I just found out after finishing doing the changes here. I ended up cherry picking @coop's commits and rebasing into my changes to have him as author. The issue he was having with
Array()was due to thePostclass being used everywhere inside the test suite. Changes to this class coming from some other place were interfering on these tests, making them fail hard. I've fixed that by renaming the class toRecordTagPost- all AP tests are green.Let me know if something should be improved.
Thanks.