Avoid loading ActionController::Base when rendering mail
#45144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactor avoids unnecessarily loading `ActionController::Base` when
loading `ActionMailer::Base`.
Before:
```
$ bin/rails r 'Benchmark.memory { |x| x.report("load"){ ActionMailer::Base } }'
Calculating -------------------------------------
load 10.013M memsize ( 1.372M retained)
78.341k objects ( 14.363k retained)
50.000 strings ( 50.000 retained)
```
After:
```
$ bin/rails r 'Benchmark.memory { |x| x.report("load"){ ActionMailer::Base } }'
Calculating -------------------------------------
load 5.043M memsize ( 729.741k retained)
38.854k objects ( 7.809k retained)
50.000 strings ( 50.000 retained)
```
This avoids unnecessarily loading `ActionController::Base` when
rendering mail after Action Text has been loaded.
Before:
```
$ bin/rails r 'Benchmark.memory { |x| x.report("load"){ MyBlankMailer.blank_email.body } }'
Calculating -------------------------------------
load 12.679M memsize ( 1.927M retained)
101.143k objects ( 19.947k retained)
50.000 strings ( 50.000 retained)
```
After:
```
$ bin/rails r 'Benchmark.memory { |x| x.report("load"){ MyBlankMailer.blank_email.body } }'
Calculating -------------------------------------
load 7.678M memsize ( 1.302M retained)
61.420k objects ( 13.644k retained)
50.000 strings ( 50.000 retained)
```
jonathanhefner
added a commit
to jonathanhefner/rails
that referenced
this pull request
Sep 23, 2022
Follow-up to rails#45144. This ensures that a renderer is always available for Action Text, even when `ActionController::Base` was not previously loaded. Fixes rails#46113. As with rails#45144, this still avoids loading `ActionController::Base` unnecessarily when rendering mail after Action Text has been loaded. **Before:** ``` $ bin/rails r 'Benchmark.memory { |x| x.report("load"){ MyBlankMailer.blank_email.body } }' Calculating ------------------------------------- load 4.466M memsize ( 1.205M retained) 29.202k objects ( 11.943k retained) 50.000 strings ( 50.000 retained) ``` **After:** ``` $ bin/rails r 'Benchmark.memory { |x| x.report("load"){ MyBlankMailer.blank_email.body } }' Calculating ------------------------------------- load 4.462M memsize ( 1.205M retained) 29.141k objects ( 11.940k retained) 50.000 strings ( 50.000 retained) ``` Co-authored-by: Christopher Louvet <cl@nonplaces.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids unnecessarily loading
ActionController::Basewhen rendering mail after Action Text has been loaded.Before:
After:
This is based on top of #45142. See the 2nd commit (c2a3ff0) for the relevant change.