Allow setting db with use_postgresql tests #45178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 25, 2022
If more than one test is using `use_postgresql` for it's tests and both need to run `db:create` those tests will fail often due to them running in parallel. I tried turning off parallelization for these tests and they still ran in separate processes. Ultimately though, turning off parallelization means we don't aren't testing parallelization. Instead I've added `Process.pid` to the database name so it creates a database specifically for that test. For cases where we need to set an explict name a name can be passed in. I also added an ensure to one of the tests so that the databases get cleaned up and not left behind. Fixes rails#45114 Fixes rails#45158
eileencodes
force-pushed
the
allow-setting-db-with-postgres
branch
from
8e3a07b
to
58f6710
Compare
eileencodes
added a commit
that referenced
this pull request
May 26, 2022
…gres Allow setting db with use_postgresql tests
eileencodes
added a commit
that referenced
this pull request
May 26, 2022
If more than one test is using `use_postgresql` for it's tests and both need to run `db:create` those tests will fail often due to them running in parallel. I tried turning off parallelization for these tests and they still ran in separate processes. Ultimately though, turning off parallelization means we don't aren't testing parallelization. Instead I've added `Process.pid` to the database name so it creates a database specifically for that test. For cases where we need to set an explict name a name can be passed in. I also added an ensure to one of the tests so that the databases get cleaned up and not left behind. Fixes #45114 Fixes #45158 Manual backport of #45178
|
I backported this to 7-0-stable and 6-1-stable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If more than one test is using
use_postgresqlfor it's tests and bothneed to create
db:createthose tests will fail often due to themrunning in parallel. I tried turning off parallelization for these tests
and they still ran in separate processes. Ultimately though, turning off
parallelization means we don't get to test parallelization. Instead I've
added the ability to set a
database_nameso that in files that requiredropping/creating the same db, we can set up a new db for those.
Fixes #45114
Fixes #45158