Update guide documentation for form_helpers.md section 1 [ci-skip] #45186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanhefner
changed the title
|
@cjilbert504 Looks good! Would you mind also squashing the commits? 🙏 Then I'll give this a merge! |
The edits in section 1.2.1 of this guide are being proposed as the value argument passed to `check_box` is not in the second position, it is the third argument as shown [here](https://api.rubyonrails.org/v7.0.3/classes/ActionView/Helpers/FormBuilder.html#method-i-check_box) and in turn the language around the argument list for `radio_button` in section 1.2.2 needed to be altered as well. Co-authored-by: Jonathan Hefner <jonathan@hefner.pro>
|
@jonathanhefner - Done! Thank you so much! |
|
Thank you, @cjilbert504! ❤️ By the way, I see you are in Covington. Neat! 😃 👋 (Backported to |
|
@jonathanhefner - I am! I see you're out there in Lafayette. We will have to meet up sometime. I go through there every now and then. 😎 |
jonathanhefner
added a commit
to jonathanhefner/rails
that referenced
this pull request
Jun 22, 2022
Update guide documentation for form_helpers.md section 1 [ci-skip] (cherry picked from commit d0bc58a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The edits in section 1.2.1 of this guide are being proposed as the value argument passed to
check_boxis not in the second position, it is the third argument as shown here and in turn the language around the argument list forradio_buttonin section 1.2.2 needed to be altered as well.