Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document ActionDispatch::TestResponse#parsed_body [ci-skip] #45189

Merged
merged 1 commit into from May 29, 2022

Conversation

shouichi
Copy link
Contributor

I found this little gem. This deserves documentation.

@rails-bot rails-bot bot added the actionpack label May 27, 2022
Copy link
Member

@jonathanhefner jonathanhefner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

actionpack/lib/action_dispatch/testing/test_response.rb Outdated Show resolved Hide resolved
@shouichi
Copy link
Contributor Author

@jonathanhefner Thanks for the feedback! I committed the suggestion and added examples.

@jonathanhefner
Copy link
Member

@shouichi Looks great! Would you mind also squashing the commits? 🙏 Then I will give this a merge!

@jonathanhefner jonathanhefner changed the title Document ActionDispatch::TestResponse#parsed_body Document ActionDispatch::TestResponse#parsed_body [ci-skip] May 28, 2022
Co-authored-by: Jonathan Hefner <jonathan@hefner.pro>
@shouichi
Copy link
Contributor Author

@jonathanhefner squashed!

@jonathanhefner jonathanhefner merged commit 6be4e96 into rails:main May 29, 2022
@jonathanhefner
Copy link
Member

jonathanhefner commented May 29, 2022

Thank you, @shouichi! 😄

(Backported to 7-0-stable.)

jonathanhefner added a commit to jonathanhefner/rails that referenced this pull request Jun 22, 2022
Document ActionDispatch::TestResponse#parsed_body [ci-skip]

(cherry picked from commit 6be4e96)
@shouichi shouichi deleted the document-parsed-body branch March 15, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants