removed redundant backtick symbol from sql examples of rails guides #45204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanhefner
approved these changes
May 29, 2022
There was a problem hiding this comment.
Even though the actual generated query may use quotes, I think this makes sense. And this is better than the current mix of backticks / double quotes / no quotes in this guide. Also, we already take liberties with the generated SQL by eliding parts of it with ....
|
Thank you, @Ivanov-Anton! 🎉 (Backported to |
jonathanhefner
added a commit
to jonathanhefner/rails
that referenced
this pull request
Jun 22, 2022
removed redundant backtick symbol from sql examples of rails guides [ci-skip] (cherry picked from commit 3fd0f84)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
to improve understanding of examples removed redundant backtick symbol from SQL examples of rails guides
Other Information