Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the API docs for third_to_last and second_to_last #45211

Merged
merged 1 commit into from
May 30, 2022
Merged

Fix the API docs for third_to_last and second_to_last #45211

merged 1 commit into from
May 30, 2022

Conversation

yykamei
Copy link
Contributor

@yykamei yykamei commented May 30, 2022

third_to_last and second_to_last seem to behave the same as #last, not #first. So, I changed the word "first" with "last."

p8
p8 approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@p8 p8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yykamei !

@p8 p8 merged commit dbbd2c1 into rails:main May 30, 2022
@yykamei yykamei deleted the patch-1 branch May 30, 2022 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p8 p8 p8 approved these changes

Assignees
No one assigned
Labels
activerecord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yykamei @p8