Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event.delete_all after UniquenessValidationWithIndexTest#test_uniqueness_on_relation #45212

Merged
merged 1 commit into from
May 30, 2022

Conversation

yahonda
Copy link
Member

@yahonda yahonda commented May 30, 2022

This pull request fixes this failure.
https://buildkite.com/rails/rails/builds/86845#018111de-9342-4b33-a792-cb06c07721e2

$ ARCONN=sqlite3 bin/test test/cases/validations/uniqueness_validation_test.rb test/cases/adapter_test.rb -n "/^(?:UniquenessValidationWithIndexTest#(?:test_uniqueness_on_relation)|ActiveRecord::AdapterTest#(?:test_select_all_insert_update_delete_with_binds|test_select_all_insert_update_delete_with_casted_binds))$/" --seed 65047
Using sqlite3
Run options: -n "/^(?:UniquenessValidationWithIndexTest#(?:test_uniqueness_on_relation)|ActiveRecord::AdapterTest#(?:test_select_all_insert_update_delete_with_binds|test_select_all_insert_update_delete_with_casted_binds))$/" --seed 65047

.E

Error:
ActiveRecord::AdapterTest#test_select_all_insert_update_delete_with_binds:
ActiveRecord::RecordNotUnique: SQLite3::ConstraintException: UNIQUE constraint failed: events.id
    /home/yahonda/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sqlite3-1.4.2/lib/sqlite3/statement.rb:108:in `step'
    /home/yahonda/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sqlite3-1.4.2/lib/sqlite3/statement.rb:108:in `block in each'
    /home/yahonda/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sqlite3-1.4.2/lib/sqlite3/statement.rb:107:in `loop'
    /home/yahonda/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sqlite3-1.4.2/lib/sqlite3/statement.rb:107:in `each'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/sqlite3/database_statements.rb:56:in `to_a'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/sqlite3/database_statements.rb:56:in `block (2 levels) in exec_query'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/concurrency/share_lock.rb:187:in `yield_shares'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/dependencies/interlock.rb:41:in `permit_concurrent_loads'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/sqlite3/database_statements.rb:47:in `block in exec_query'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `handle_interrupt'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `block in synchronize'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `handle_interrupt'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `synchronize'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:830:in `block in log'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications/instrumenter.rb:24:in `instrument'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:821:in `log'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/sqlite3/database_statements.rb:46:in `exec_query'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:132:in `exec_insert'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:167:in `insert'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb:22:in `insert'
    /home/yahonda/src/github.com/rails/rails/activerecord/test/cases/adapter_test.rb:264:in `test_select_all_insert_update_delete_with_binds'

bin/test test/cases/adapter_test.rb:260

E

Error:
ActiveRecord::AdapterTest#test_select_all_insert_update_delete_with_casted_binds:
ActiveRecord::RecordNotUnique: SQLite3::ConstraintException: UNIQUE constraint failed: events.id
    /home/yahonda/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sqlite3-1.4.2/lib/sqlite3/statement.rb:108:in `step'
    /home/yahonda/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sqlite3-1.4.2/lib/sqlite3/statement.rb:108:in `block in each'
    /home/yahonda/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sqlite3-1.4.2/lib/sqlite3/statement.rb:107:in `loop'
    /home/yahonda/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sqlite3-1.4.2/lib/sqlite3/statement.rb:107:in `each'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/sqlite3/database_statements.rb:56:in `to_a'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/sqlite3/database_statements.rb:56:in `block (2 levels) in exec_query'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/concurrency/share_lock.rb:187:in `yield_shares'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/dependencies/interlock.rb:41:in `permit_concurrent_loads'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/sqlite3/database_statements.rb:47:in `block in exec_query'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `handle_interrupt'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `block in synchronize'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `handle_interrupt'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `synchronize'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:830:in `block in log'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications/instrumenter.rb:24:in `instrument'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:821:in `log'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/sqlite3/database_statements.rb:46:in `exec_query'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:132:in `exec_insert'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:167:in `insert'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb:22:in `insert'
    /home/yahonda/src/github.com/rails/rails/activerecord/test/cases/adapter_test.rb:244:in `test_select_all_insert_update_delete_with_casted_binds'

bin/test test/cases/adapter_test.rb:240

Finished in 0.041846s, 71.6915 runs/s, 95.5887 assertions/s.
3 runs, 4 assertions, 0 failures, 2 errors, 0 skips
$

Summary

Other Information

…ness_on_relation`

Fixed this failure.
https://buildkite.com/rails/rails/builds/86845#018111de-9342-4b33-a792-cb06c07721e2

```
$ ARCONN=sqlite3 bin/test test/cases/validations/uniqueness_validation_test.rb test/cases/adapter_test.rb -n "/^(?:UniquenessValidationWithIndexTest#(?:test_uniqueness_on_relation)|ActiveRecord::AdapterTest#(?:test_select_all_insert_update_delete_with_binds|test_select_all_insert_update_delete_with_casted_binds))$/" --seed 65047
Using sqlite3
Run options: -n "/^(?:UniquenessValidationWithIndexTest#(?:test_uniqueness_on_relation)|ActiveRecord::AdapterTest#(?:test_select_all_insert_update_delete_with_binds|test_select_all_insert_update_delete_with_casted_binds))$/" --seed 65047

.E

Error:
ActiveRecord::AdapterTest#test_select_all_insert_update_delete_with_binds:
ActiveRecord::RecordNotUnique: SQLite3::ConstraintException: UNIQUE constraint failed: events.id
    /home/yahonda/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sqlite3-1.4.2/lib/sqlite3/statement.rb:108:in `step'
    /home/yahonda/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sqlite3-1.4.2/lib/sqlite3/statement.rb:108:in `block in each'
    /home/yahonda/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sqlite3-1.4.2/lib/sqlite3/statement.rb:107:in `loop'
    /home/yahonda/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sqlite3-1.4.2/lib/sqlite3/statement.rb:107:in `each'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/sqlite3/database_statements.rb:56:in `to_a'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/sqlite3/database_statements.rb:56:in `block (2 levels) in exec_query'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/concurrency/share_lock.rb:187:in `yield_shares'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/dependencies/interlock.rb:41:in `permit_concurrent_loads'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/sqlite3/database_statements.rb:47:in `block in exec_query'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `handle_interrupt'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `block in synchronize'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `handle_interrupt'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `synchronize'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:830:in `block in log'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications/instrumenter.rb:24:in `instrument'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:821:in `log'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/sqlite3/database_statements.rb:46:in `exec_query'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:132:in `exec_insert'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:167:in `insert'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb:22:in `insert'
    /home/yahonda/src/github.com/rails/rails/activerecord/test/cases/adapter_test.rb:264:in `test_select_all_insert_update_delete_with_binds'

bin/test test/cases/adapter_test.rb:260

E

Error:
ActiveRecord::AdapterTest#test_select_all_insert_update_delete_with_casted_binds:
ActiveRecord::RecordNotUnique: SQLite3::ConstraintException: UNIQUE constraint failed: events.id
    /home/yahonda/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sqlite3-1.4.2/lib/sqlite3/statement.rb:108:in `step'
    /home/yahonda/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sqlite3-1.4.2/lib/sqlite3/statement.rb:108:in `block in each'
    /home/yahonda/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sqlite3-1.4.2/lib/sqlite3/statement.rb:107:in `loop'
    /home/yahonda/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sqlite3-1.4.2/lib/sqlite3/statement.rb:107:in `each'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/sqlite3/database_statements.rb:56:in `to_a'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/sqlite3/database_statements.rb:56:in `block (2 levels) in exec_query'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/concurrency/share_lock.rb:187:in `yield_shares'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/dependencies/interlock.rb:41:in `permit_concurrent_loads'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/sqlite3/database_statements.rb:47:in `block in exec_query'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `handle_interrupt'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `block in synchronize'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `handle_interrupt'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `synchronize'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:830:in `block in log'
    /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications/instrumenter.rb:24:in `instrument'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:821:in `log'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/sqlite3/database_statements.rb:46:in `exec_query'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:132:in `exec_insert'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:167:in `insert'
    /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb:22:in `insert'
    /home/yahonda/src/github.com/rails/rails/activerecord/test/cases/adapter_test.rb:244:in `test_select_all_insert_update_delete_with_casted_binds'

bin/test test/cases/adapter_test.rb:240

Finished in 0.041846s, 71.6915 runs/s, 95.5887 assertions/s.
3 runs, 4 assertions, 0 failures, 2 errors, 0 skips
$
```
@yahonda yahonda merged commit 55ba72b into rails:main May 30, 2022
@yahonda yahonda deleted the diag86845 branch May 30, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant