Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop test databases if exist for PG ActiveRecord test setup #45214

Merged
merged 1 commit into from
May 30, 2022
Merged

Drop test databases if exist for PG ActiveRecord test setup #45214

merged 1 commit into from
May 30, 2022
+2 −2

Conversation

JuanitoFatas
Copy link
Contributor

@JuanitoFatas JuanitoFatas commented May 30, 2022 •
edited

Summary

I saw from the job log has these error notices:

CleanShot 2022-05-30 at 20 14 19@2x

I think we can pass a if exists flag to avoid these error notices.

@yahonda
Copy link
Member

yahonda commented May 30, 2022

dropdb --if-exists option is available at PostgreSQL 9.3 which is the minimum requirement for Rails 7.1 so I think it is safe to merge.

https://www.postgresql.org/docs/9.3/app-dropdb.html

@yahonda yahonda merged commit 381bd08 into rails:main May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
activerecord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JuanitoFatas @yahonda