Fix store dirty tracking documentation [ci-skip] #45224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
When you're finished with the changes, would you mind squashing the commits? 🙏
activerecord/CHANGELOG.md
Outdated
Comment on lines
1
to
4
| * Fix Store dirty tracking documentation | ||
|
|
||
| *dmichaux* | ||
|
|
There was a problem hiding this comment.
We usually don't add CHANGELOG entries for documentation fixes, so let's omit this.
There was a problem hiding this comment.
Thanks. I took out the CHANGELOG change and it's down to 1 commit.
jonathanhefner
changed the title
dmichaux
force-pushed
the
fix-store-dirty-tracking-documentation
branch
from
a91a6cb
to
9348e19
Compare
|
Thank you, @dmichaux! 🎉 (Backported to |
jonathanhefner
added a commit
to jonathanhefner/rails
that referenced
this pull request
Jun 22, 2022
…-documentation Fix store dirty tracking documentation [ci-skip] (cherry picked from commit 2d62fd0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an error in the code example for dirty tracking in ActiveRecord::Store.