Remove 4 unroutable routes from ActionMailbox #45230
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I was auditing which routes in my app do not actually a have corresponding controller action. ActionMailbox's inbound_emails has these 4 routes defined, which do not actually work.
Other Information
Here's the corresponding controller, where you can see that only 4 actions are defined, not 7.
https://github.com/rails/rails/blob/ef52dd906ed4ef9f1578119e27b712d11e68009d/actionmailbox/app/controllers/rails/conductor/action_mailbox/inbound_emails_controller.rb