MemCacheStore shorten keys properly #45245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akostadinov
force-pushed
the
cache_hash
branch
2 times, most recently
from
dac12df
to
3ceb7cd
Compare
byroot
requested changes
Jun 7, 2022
11 tasks
|
I have also split tests into separate methods. Thank you for the input. |
|
Please squash your commits, and I'll happily merge. |
The logic for shortening long keys in MemCacheStore is broken since the time it stopped using MD5 checksumming. Memcached supports keys up to 250 chars length. The reason things worked I believe is because the underlying Dalli library is doing it's own key shortening. Which uses its own hashing function and in fact limits keys to 249 chars, see petergoldstein/dalli@74b2625 This patch in a similar way properly truncates keys to 250 characters and avoids double hashing on Dalli side. Also makes key name more predictable and independent from the underlying Dalli version.
|
squashed, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for shortening long keys in MemCacheStore
is broken since the time it stopped using MD5 checksumming.
Memcached supports keys up to 250 chars length. The reason
things worked I believe is because the underlying Dalli
library is doing it's own key shortening. Which uses its own
hashing function and in fact limits keys to 249 chars, see
petergoldstein/dalli@74b2625
This patch in a similar way properly truncates keys to 250
characters and avoids double hashing on Dalli side. Also
makes key name more predictable and independent from the
underlying Dalli version.