swap misnamed variables of arel with terms #45250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the recursive and non recursive term variables were misnamed. Now The naming conforms to the syntax as described in https://www.postgresql.org/docs/14/queries-with.html#QUERIES-WITH-RECURSIVE and shows which way around the union of the two terms in the with statement needs to happen.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
the recursive and non recursive term variables were misnamed. Now The
naming conforms to the syntax as described in
https://www.postgresql.org/docs/14/queries-with.html#QUERIES-WITH-RECURSIVE
and shows which way around the union of the two terms in the with
statement needs to happen.
Although this does not change how the code runs, it does prevent confusion for the reader.