Fix includes of deprecation proxy modules #45251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
changed the title
Previously, including/prepending/extending one of these deprecated constants would silently succeed, since it is a module. This adds a defintion for append_features/prepend_features/extended so that it can forward the inclusion onto the target module.
The first argument to DeprecatedConstantProxy should be the old constant name. I suspect this was automatically corrected by accident.
jhawthorn
force-pushed
the
deprecated_constant_for_module
branch
from
9781966
to
c81a9bc
Compare
matthewd
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously (at least since #36557), including/prepending/extending one of these deprecated constants would silently succeed, since the proxy is a module.
This adds a defintion for append_features/prepend_features/extended so that it can forward the inclusion onto the target module and issue the deprecation warning.
I noticed this due to the change in #45180