Refactor clearing cache on handler #45260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method was left over from when we had 2 kinds of connection management. Now that we no longer have multiple handlers and there can only be one, there's no reason to have this refactored to a separate method. If we end up reimplementing rails#40622 the connection specification name can be passed to `clear_query_caches_for_current_thread` instead. However I'm still concerned that switching from clearing all connections to only clearing per connection name will break existing applications that are dependent on this behavior.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was left over from when we had 2 kinds of connection
management. Now that we no longer have multiple handlers and there can
only be one, there's no reason to have this refactored to a separate
method.
If we end up reimplementing #40622 the connection specification name can
be passed to
clear_query_caches_for_current_threadinstead. HoweverI'm still concerned that switching from clearing all connections to only
clearing per connection name will break existing applications that are
dependent on this behavior.