Show Guides Index as selected for / on small screens [ci-skip]
#45277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On small screens the guides index is shown as a select dropdown. The Guides Index option has the value 'index.html'. When visiting `https://guides.rubyonrails.org/` this option won't be selected as the pathname doesn't include index.html. Javascript treats empty strings as falsey, so for the root path we can return `index.html` instead of a empty string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On small screens the guides index is shown as a select dropdown.
If the
window.locationmatches the value of an option, it will be selected.The first option in the
selectis "Guides Index" and has the value 'index.html'.When visiting
https://guides.rubyonrails.org/index.htmlthis option is selected.When visiting
https://guides.rubyonrails.org/this option won't beselected as the pathname doesn't include index.html.
Javascript treats empty strings as falsey, so for the root path we can
return
index.htmlinstead of an empty string.This makes sure the "Guides Index" is selected as well.
Before
After