Add info and fix command description [ci-skip] #45336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Some small tweaks, but looks good! 👍
When you're happy with all the changes, would you mind squashing the commits?
guides/source/command_line.md
Outdated
| @@ -42,13 +42,13 @@ $ rails new commandsapp | |||
| run bundle install | |||
| ``` | |||
|
|
|||
| Rails will set you up with what seems like a huge amount of stuff for such a tiny command! You've got the entire Rails directory structure now with all the code you need to run our simple application right out of the box. | |||
| Rails will set us up with what seems like a huge amount of stuff for such a tiny command! We've got the entire Rails directory structure now with all the code we need to run our simple application right out of the box. | |||
There was a problem hiding this comment.
Suggested change
| Rails will set us up with what seems like a huge amount of stuff for such a tiny command! We've got the entire Rails directory structure now with all the code we need to run our simple application right out of the box. | |
| Rails will set up what seems like a huge amount of stuff for such a tiny command! We've got the entire Rails directory structure now with all the code we need to run our simple application right out of the box. |
guides/source/command_line.md
Outdated
|
|
||
| | Argument | Description | | ||
| | ----------------------- | ----------------------------------------------------------- | | ||
| | `--skip-git` | Skip .gitignore file | | ||
| | `--skip-git` | Skip git init, .gitignore, and .gitattributes | |
There was a problem hiding this comment.
Suggested change
| | `--skip-git` | Skip git init, .gitignore, and .gitattributes | | |
| | `--skip-git` | Skip git init, .gitignore, and .gitattributes | |
guides/source/command_line.md
Outdated
| @@ -65,6 +65,8 @@ If you wish to skip some files or components from being generated, you can appen | |||
| | `--skip-system-test` | Skip system test files | | |||
| | `--skip-bootsnap` | Skip bootsnap gem | | |||
|
|
|||
| INFO: These are just some of the options you can append to `rails new`. For a comprehensive list of options, type `rails new --help`. | |||
There was a problem hiding this comment.
Let's skip the INFO: callout here. I don't think it adds anything, and too many callouts in a guide can be distracting.
Suggested change
| INFO: These are just some of the options you can append to `rails new`. For a comprehensive list of options, type `rails new --help`. | |
| These are just some of the options that `rails new` accepts. For a full list of options, type `rails new --help`. |
|
I think I'm happy with the changes now :) @jonathanhefner |
|
Thank you, @siaw23! 🎉 (Backported to |
jonathanhefner
added a commit
to jonathanhefner/rails
that referenced
this pull request
Jun 25, 2022
Add info and fix command description [ci-skip] (cherry picked from commit 53efecd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Other Information