Move db and shard selector initalizer to Railties #45368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rails#45162 it was discovered that the multi_db generator that was created for 7.0 doesn't work correctly because that file is loaded _after_ the initializer in active record is run. I tried moving everything to an after_initialize but the middleware stack is frozen at that point. I also attempted to fix this in rails#45353 but it just didn't feel right to have to deprecate this behavior that _should_ work. I then realized that most of the middleware in Rails is installed in the middleware stack file in railties. If I move the middleware installation to this file, everything works as necessary. The only caveat is we need to check if `config` responds to `active_record` but I think that should be fine - we already do that in the framework defaults configuration. Fixes rails#45162
eileencodes
force-pushed
the
move-db-and-shard-selector-middleware-to-railtie
branch
from
6c7761d
to
d179383
Compare
eileencodes
added a commit
that referenced
this pull request
Jun 15, 2022
…-middleware-to-railtie Move db and shard selector initalizer to Railties
|
Backported to 7-0-stable in 7f5015a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #45162 it was discovered that the multi_db generator that was created
for 7.0 doesn't work correctly because that file is loaded after the
initializer in active record is run. I tried moving everything to an
after_initialize but the middleware stack is frozen at that point. I
also attempted to fix this in #45353 but it just didn't feel right to
have to deprecate this behavior that should work.
I then realized that most of the middleware in Rails is installed in the
middleware stack file in railties. If I move the middleware installation
to this file, everything works as necessary.
The only caveat is we need to check if
configresponds toactive_recordbut I think that should be fine - we already do that inthe framework defaults configuration.
Fixes #45162